Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all tests to gym/tests/... #2425

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Conversation

RedTachyon
Copy link
Contributor

See Issue #2424

This is kinda WIP, we have to make sure that all the tests actually trigger and pass.

Also from a quick local test it seems that some of the tests have internal imports. PyCharm did its best to convert them, but it might need some more attention.

@jkterry1
Copy link
Collaborator

@RedTachyon this tentatively looks good to me, however the first 4 file renames shown in the files changed tab don't make a lot of sense to me?

@RedTachyon
Copy link
Contributor Author

@jkterry1 Do you mean gym/envs/tests/__init__.py → gym/tests/__init__.py etc?

It's marked as renames, but my guess is that it's the diff failing to understand moved files. There was a bunch of inits in the previous version under gym/envs/tests, gym/wrappers/tests, and now there's a bunch of inits under gym/tests/envs, gym/tests/wrappers and so on. So it tried to map the former to the latter, but it got a bit wonky in the process because in the end it's just all empty __init__s

@jkterry1
Copy link
Collaborator

I mean things like "gym/spaces/tests/init.py → gym/tests/envs/init.py"

@jkterry1
Copy link
Collaborator

Oh, no that should be a bad diff. You're right.

@jkterry1 jkterry1 merged commit 3331efe into openai:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants