Avoid explicit reading of /etc/salt/minion (bsc#1220357) #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parcial backport of saltstack/salt#65696 with saltstack/salt@d54407b from upstream PR only.
Upstream PR is messy and contains a list of changes not related to the original description.
I'm closing previous PR #641 in favor of this one.
In some cases
salt-callon the salt-ssh client side is rereading/etc/salt/minionexplicitly what doesn't make any sense.What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/23799
Previous Behavior
In some cases
salt-callon the salt-ssh client side is rereading/etc/salt/minion.New Behavior
Prevent
salt-callof rereading/etc/salt/minionwith no reason.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.