Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test workflows based on salt-test #616

Merged
merged 25 commits into from
Feb 26, 2024
Merged

Add test workflows based on salt-test #616

merged 25 commits into from
Feb 26, 2024

Commits on Feb 12, 2024

  1. Add unit test workflow based on salt-test

    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    25c1589 View commit details
    Browse the repository at this point in the history

  2. Add integration test workflow based on salt-test

    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    8a1c0e4 View commit details
    Browse the repository at this point in the history

  3. Align boto imports in tests with Salt modules 

    Some modules `import boto` to set log levels. The related tests don't
import `boto`. This can cause a problem when `boto` is not available.

Tests are skipped when HAS_BOTO in the test_boto_*.py is False. Not
trying to `import boto` can leave HAS_BOTO=True in the test file even
though HAS_BOTO is False on the application side. In this case, tests
are not skipped and fail.
    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7961890 View commit details
    Browse the repository at this point in the history

  4. Fix mock order in test_dig (test_network.py) 

    `salt.utils.path.which` should not be mocked before `network.__utils__`. The
Salt loader calls `salt.utils.network.linux_interfaces`, which needs the real
`salt.utils.path.which`.
    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    9e33dd2 View commit details
    Browse the repository at this point in the history

  5. Fix mock calls 

    Signed-off-by: Pedro Algarvio <[email protected]>
(cherry picked from commit 3506e7f)
    @s0undt3ch @agraul
    s0undt3ch authored and agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    12fdbff View commit details
    Browse the repository at this point in the history

  6. Skip venafiapi test if vcert module not available 

    The same HAS_VCERT check is done in the runner module.
    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7c3b84a View commit details
    Browse the repository at this point in the history

  7. Moving tests/integration/modules/test_cmdmod.py to pytest, Gareth J G… 

    …reenaway original author

(cherry picked from commit 2c1040b)
    @garethgreenaway @agraul
    garethgreenaway authored and agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6789525 View commit details
    Browse the repository at this point in the history

  8. The repo.saltproject.io index.html file changed it's contents. Fix … 

    …tests.

Signed-off-by: Pedro Algarvio <[email protected]>
(cherry picked from commit 672f658)
    @s0undt3ch @agraul
    s0undt3ch authored and agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    279a461 View commit details
    Browse the repository at this point in the history

  9. Skip hwclock test when executed inside a container

    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1b066da View commit details
    Browse the repository at this point in the history

  10. Skip git pillar tests when executed inside a container 

    These tests require a Git repository container, which is hard to correctly set
up when executing the tests in the container in GH Actions.

Using --network host can help, but there was still an error (the git repos were
empty) when I tried to set this up.
    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    cf5699a View commit details
    Browse the repository at this point in the history

  11. Skip test requiring systemd inside container

    @agraul
    agraul committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3ada277 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Exclude tests for hgfs if missing hglib

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    73498d2 View commit details
    Browse the repository at this point in the history

  2. Adjust GH actions to run all tests subsets and include functional

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2e2dcde View commit details
    Browse the repository at this point in the history

  3. Add new GH action to trigger scenarios tests

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    840d73c View commit details
    Browse the repository at this point in the history

  4. Skip and fix tests when running on containers

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9f09aa7 View commit details
    Browse the repository at this point in the history

  5. Fix some failing test causing problem in SUSE environments

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c4a2186 View commit details
    Browse the repository at this point in the history

  6. Skip more tests when running on containers

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    0ba8be1 View commit details
    Browse the repository at this point in the history

  7. Use skipif instead of skip_if as it seems not behaving equally

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    44662a6 View commit details
    Browse the repository at this point in the history

  8. Skip more tests that cannot run in a container

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5554064 View commit details
    Browse the repository at this point in the history

  9. Remove SSH test which doesn't make sense after lock mechanism

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a966469 View commit details
    Browse the repository at this point in the history

  10. Fix failing boto tests

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8d169f5 View commit details
    Browse the repository at this point in the history

  11. Skip unmaintained tests upstream around zcbuildout

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    1ba30b1 View commit details
    Browse the repository at this point in the history

  12. Arrange GH actions into fast and full executions

    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    cb87472 View commit details
    Browse the repository at this point in the history

  13. GH Actions: Fix Salt version in _version.txt file 

    When GH Actions are executed, they skip the default entrypoint for the
container, so we need to arrange the _version.txt file manually
    @meaksh
    meaksh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    bc8bfdf View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Skip some tests that does not run well in GH Actions 

    Propagate GITHUB_ACTIONS variable to container environment
    @meaksh
    meaksh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c7be52c View commit details
    Browse the repository at this point in the history