Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ignore and skip tests to the list #2

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented Jan 3, 2024

Based on the initial Salt Shaker runs, these are some tests we need to ignore to prevent errors and also skip to avoid hanging executions.

@cboltz
Copy link
Member

cboltz commented Jan 3, 2024

Let me quote the README:

All changes must come via a pull request that is approved by at least two other maintainers. All new entries must include a comment that explains why a given test is failing. The pull request description should explain why a test case is not getting fixed and instead added to this skiplist.

I'm afraid both your commit message and the actual changes don't fulfil these requirements.

skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Show resolved Hide resolved
@meaksh meaksh changed the title WIP: Add more ignore and skip tests to the list Add more ignore and skip tests to the list Feb 14, 2024
@meaksh meaksh requested a review from agraul February 14, 2024 15:56
Copy link
Member

@agraul agraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to see how hard it is to fix the boto-related tests. I found out that many of them are due to a misalignment between imports in tests and imports in the application. In that case HAS_BOTO is True for the tests but False for the application.

Other than that, I would drop tests we don't plan to fix. If they are unmaintained by us and by upstream, I doubt they will be fixed.

skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
skipped_tests.toml Outdated Show resolved Hide resolved
@meaksh
Copy link
Member Author

meaksh commented Feb 15, 2024

Thanks for the feedback @agraul. I've removed the ones that are not longer needed after the changes we are introducing here: openSUSE/salt#616

@meaksh meaksh requested a review from agraul February 15, 2024 16:30
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boto tests surprised a bit, but after reading the comments it's clear now :-)

@meaksh meaksh merged commit bbebaf5 into main Feb 21, 2024
@meaksh meaksh deleted the main-fix-skiplist branch February 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants