-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ignore and skip tests to the list #2
Conversation
Let me quote the README:
I'm afraid both your commit message and the actual changes don't fulfil these requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to see how hard it is to fix the boto-related tests. I found out that many of them are due to a misalignment between imports in tests and imports in the application. In that case HAS_BOTO
is True
for the tests but False
for the application.
Other than that, I would drop tests we don't plan to fix. If they are unmaintained by us and by upstream, I doubt they will be fixed.
Thanks for the feedback @agraul. I've removed the ones that are not longer needed after the changes we are introducing here: openSUSE/salt#616 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boto tests surprised a bit, but after reading the comments it's clear now :-)
Based on the initial Salt Shaker runs, these are some tests we need to ignore to prevent errors and also skip to avoid hanging executions.