-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetApp ONTAP formula #31
Draft
tacerus
wants to merge
34
commits into
openSUSE:main
Choose a base branch
from
tacerus:new/netapp_ontap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New formula for managing NetApp ONTAP devices. This is intended to replace the LUN/disk management parts in the messy orchestration modules. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Handle executions with multiple tasks. Facilitate more REST operations in results parsing. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Split into two functions, one to query whether the LUN is mapped at all, and onne to query details about the mapping. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Initial state module. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
tacerus
force-pushed
the
new/netapp_ontap
branch
from
June 24, 2023 06:56
fff4e7e
to
0982673
Compare
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
tacerus
force-pushed
the
new/netapp_ontap
branch
from
June 24, 2023 06:58
0982673
to
bc7b084
Compare
Add some comments, make igroup filter in get_lun_mapped() optional, show comment in get_lun() output, drop single-use _config() function. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Add basic explanations to the functiosn in ontap_native. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Split into get_lun_mapping() and get_lun_mappings(). Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Drop useless logic for multiple mapping results. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Add unmap_lun() for unmapping of a single LUN and the matching lun_unmapped() state function. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
The Ansible based "ontap" execution module is not pursued anymore. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
These are no longer used, as the Salt modules now communicate with the ONTAP Python library natively. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Drop old mapping logic (LUN's are now to be mapped using "lun_mapped" instead), use paths instead of comments for validation. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Initial test structure. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
- use shared LUN fixture - add coverage for deletion and update operations Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to become a replacement for the messy LUN management code in the orchestra formula. The functionality is now implemented with proper Salt modules and correct
test=True
operation, and is easily expandable for ONTAP operations beyond LUN management.Ironically, this replacement still uses Ansible as a middleware, but the new layout should make switching to direct interaction with the NetApp Python library easier should this be desired in the future.