Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the leak of names of all the users #1906

Closed
wants to merge 1 commit into from

Conversation

anmoliiitd823
Copy link

Closes #1884
Before
screenshot from 2017-12-21 15-23-07

After
screenshot from 2017-12-21 16-03-02

@differentreality
Copy link
Contributor

Hi @anmoliiitd823
aren't those 2 screenshots the same? Or am I missing something?

Can you please explain how you are solving the issue by removing id field from the collection?

In the future, please prefer to work on issues that are labeled, which means the maintainers have confirmed them. Thank you :)

@anmoliiitd823
Copy link
Author

As during the sign up form it is written that other users can only view the usernames.So I only removed the name of the user.
screenshot from 2017-12-18 00-05-45
In the Before screenshot any user can view the real names of other users also which violates the statement written during the sign-up form.

@differentreality
Copy link
Contributor

@anmoliiitd823 thank you for trying this out and Happy New Year!
I am pretty sure the point of the issue was the whole idea of the search box itself.

I would strongly suggest you focus on issues that are labeled, starting with a few labeled Junior or good first issue.

I will close this PR - don't let that discourage you though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants