Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add withhistory, withbinaries and makeoriginolder to copypac #1104

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Aug 17, 2022

Apparently the code is OK, but OBS does not like witthistory.

$ ./osc-wrapper.py -v copypac -W -w systemsmanagement:Uyuni:Master spacewalk home:juliogonzalezgil:branches:systemsmanagement:Uyuni:Master
makeurl: https://api.opensuse.org ['source', 'systemsmanagement:Uyuni:Master', 'spacewalk'] {'rev': 'latest'}
makeurl: https://api.opensuse.org ['source', 'systemsmanagement:Uyuni:Master', 'spacewalk', '_meta'] {}
makeurl: https://api.opensuse.org ['source/home%3Ajuliogonzalezgil%3Abranches%3Asystemsmanagement%3AUyuni%3AMaster/spacewalk/_meta'] {}
Copying files...
makeurl: https://api.opensuse.org ['source', 'home:juliogonzalezgil:branches:systemsmanagement:Uyuni:Master', 'spacewalk'] {'cmd': 'copy', 'oproject': 'systemsmanagement:Uyuni:Master', 'opackage': 'spacewalk', 'orev': '76', 'comment': 'osc copypac from project:systemsmanagement:Uyuni:Master package:spacewalk revision:76, including history, including binaries', 'withhistory': '1', 'withbinaries': '1'}
Server returned an error: HTTP Error 400: Bad Request
unknown parameter 'withhistory'

I still need to figure out what's wrong.

According to @hennevogel:

POST /source//?cmd=copy&withhistory=1&oproject=source_project&opackage=source_package

Should work.

And I see the parameter at https://build.openbuildservice.org/apidocs/index for copy

So I am not sure what I am missing here.

@pep8speaks
Copy link

pep8speaks commented Aug 17, 2022

Hello @juliogonzalez! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-17 18:15:37 UTC

@juliogonzalez
Copy link
Member Author

juliogonzalez commented Aug 17, 2022

Ooops... I was not expecting tests running for a DRAFT, but I will fix the pep errors right away.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1104 (34985bc) into master (f86fb66) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   22.99%   22.99%   -0.01%     
==========================================
  Files          27       27              
  Lines       15725    15740      +15     
==========================================
+ Hits         3616     3619       +3     
- Misses      12109    12121      +12     
Impacted Files Coverage Δ
osc/core.py 35.44% <0.00%> (-0.04%) ⬇️
osc/commandline.py 14.59% <33.33%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dmach
Copy link
Contributor

dmach commented Mar 9, 2023

This pull request has been in a draft state for quite some time.
Could you either finish it, close it or add a comment that you're still planning to work on it?

@adrianschroeter
Copy link
Member

some of these are admin-only flags, not sure if it makes sense to add this to generic osc commands...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants