Work around init_buildsystem occasionally failing to unmount old buildroot over NFS #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld_root() recreates corresponding files
…uild root asynchronously, so stale NFS objects do not block a new running build
…check()" : after trying to just unmount, also try forced lazy unmounts to quickly remove the subtrees from visibility of RM commands which follow
…check()" : add some visibility to the activity
…check()" : attempt to stop processes running inside build root
adrianschroeter
force-pushed
the
master
branch
from
e6ebce5
to
2a6beef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our practice, sometimes the
umountcommands in theinit_buildsystemscript failed to deliver, especially against NFS build roots where some hiccup caused its files or directories to get stale at the wrong moment.So they were augmented by forced+lazy unmounts, which ensured that subsequent file-deleting spree did not impact bind-mounted system directories, and later by asynchronous deletion of old build root so we do not block a new build on currently unremovable objects. Finally, recreate some things we've just deleted that were created by the
buildscript a second before this...