Drop automatic inclusion of .pc file for baselibs. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openSUSE#724. Avoid default inclusion of pkgconfig files in automatically generated baselibs configured biarch packages. This avoids the "have choice" issue seen with `BuildRequires: pkgconfig(FOO)` type dependencies on OBS for any dependents of a biarch FOO-devel package. It is wrong to ask every project supporting biarch devel packages to configure project macros to disfavour one pkgconfig based dependency in favour of another. Packager may at their wish explicitly include the pkgconfig file in the biarch package explicitly by appropriately configure the associated baselibs.conf file, but as a default, this should be hardly ever required.
|
Ping? |
|
See https://bugzilla.suse.com/show_bug.cgi?id=1172563, which asked for adding the .pc files. |
|
Thanks for the reference. Looks to me like the missing piece of the puzzle — correct RPM autoprovides for baselibs — has been missing for a while. From reading that bug report, it seems everyone pretty much agrees that packaging .pc files for the baselibs without first correcting the autoprovs is a mistake that is haphazardly worked around in Factory but needs similar hackish workarounds for every project using these biarch libs. I would still suggest skipping automatic inclusion of these .pc files. |
|
Off the top of my head, the other option would be to turn off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724.
Avoid default inclusion of pkgconfig files in automatically generated baselibs configured biarch packages. This avoids the "have choice" issue seen with
BuildRequires: pkgconfig(FOO)type dependencies on OBS for any dependents of a biarch FOO-devel package. It is wrong to ask every project supporting biarch devel packages to configure project macros to disfavour one pkgconfig based dependency in favour of another.Packager may at their wish explicitly include the pkgconfig file in the biarch package explicitly by appropriately configure the associated baselibs.conf file, but as a default, this should be hardly ever required.