Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: fix RPM specfile groups, call ldconfig directly #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dist: fix RPM specfile groups, call ldconfig directly #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions libstorage-ng.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Version: @VERSION@
Release: 0
Summary: Library for storage management
License: GPL-2.0
Group: System/Libraries
Group: Development/Libraries/C and C++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? What are the definitions for those two groups?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System/Libraries: "Packages in this group should already be installed automatically because of a dependency." libstorage-ng.src.rpm (that is what line 25 touches here) however neither contains a .so file, nor does it get autoinstalled.
More group descriptions are on https://en.opensuse.org/openSUSE:Package_group_guidelines#System .

Url: http://github.com/openSUSE/libstorage-ng
Source: libstorage-ng-%{version}.tar.bz2
%if 0%{?suse_version} >= 1330
Expand Down Expand Up @@ -108,15 +108,15 @@ libstorage-ng.

%package -n libstorage-ng-python
Summary: Python bindings for libstorage-ng
Group: System/Libraries
Group: Development/Languages/Python
Requires: %{libname} = %{version}

%description python
This package contains Python bindings for libstorage-ng.

%package -n libstorage-ng-ruby
Summary: Ruby bindings for libstorage-ng
Group: System/Libraries
Group: Development/Languages/Ruby
Requires: %{libname} = %{version}

%description ruby
Expand Down Expand Up @@ -158,9 +158,7 @@ touch %{buildroot}/run/libstorage/lock

%find_lang libstorage-ng

%post -n %{libname}
/sbin/ldconfig

%post -n %{libname} -p /sbin/ldconfig
%postun -n %{libname} -p /sbin/ldconfig

%files -n %{name}-lang -f libstorage-ng.lang
Expand Down