Scope of validate --validate-images
is different from validate
& validate --validate-ids
#627
Labels
validate --validate-images
is different from validate
& validate --validate-ids
#627
Problem description
Both normal XML validation (
validate
) and ID validation (validate --validate-ids
) check the entire document, ignoring the ROOTID.Image validation (
validate --validate-images
) however, is checking only within the scope of the ROOTID.Within our GHA CI, this is now a practical issue -- we optimize the number of documents we validate based on the assumption that the ROOTID will be ignored. That is only true for 2/3 of the checks we run, though. This means that in some cases, our CI will overlook the fact that images are missing and falsely give a positive result (cf. openSUSE/doc-ci#30).
(This issue is not completely new, it did exist within our Travis CI script already. However, the GHA script adds an automatic optimization of which DC files to validate, so the issue is exacerbated compared to our previous manual optimizations applied via the
.travis-check-docs
file in our repos.)Expected behavior
Make sure all behaviors of the
validate
target are scoped the same way. As I don't really want to touch the CI too much, I'd selfishly suggest ignoring the ROOTID parameter for the entirevalidate
target.Steps to reproduce problem
Check out the broken state of SUSE/doc-sle@15f3b21 and run
validate --validate-images
orlist-images-missing
with different DC files:The text was updated successfully, but these errors were encountered: