ADIOS2: Support NULL-Blocks (Chunks) #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2023
ax3l
force-pushed
the
fix-support-null-blocks
branch
3 times, most recently
from
f49bef1
to
26ac8f5
Compare
Add support to read back ADIOS2 data sets that contain empty blocks (NULL chunks). This is something to handle carefully and needed for a work-arounds in WarpX BTD.
ax3l
force-pushed
the
fix-support-null-blocks
branch
from
26ac8f5
to
f11cdd3
Compare
RemiLehe
approved these changes
Feb 2, 2023
ax3l
commented
Oct 26, 2023
| @@ -66,6 +66,15 @@ def get_data(series, record_component, i_slice=None, pos_slice=None, | |||
| data = np.full(record_component.shape, np.nan, record_component.dtype) | |||
| for chunk in chunks: | |||
| chunk_slice = chunk_to_slice(chunk) | |||
|
|
|||
| # skip empty slices | |||
| # https://github.com/ornladios/ADIOS2 | |||
There was a problem hiding this comment.
Should read ornladios/ADIOS2#3459
ax3l
commented
Oct 26, 2023
| @@ -98,6 +107,15 @@ def get_data(series, record_component, i_slice=None, pos_slice=None, | |||
| s_valid = list(s) # same as s but reduced to valid regions in chunk | |||
| s_target = [] # starts and stops in sliced array | |||
| chunk_slice = chunk_to_slice(chunk) | |||
|
|
|||
| # skip empty slices | |||
| # https://github.com/ornladios/ADIOS2 | |||
There was a problem hiding this comment.
Should read ornladios/ADIOS2#3459
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to read back ADIOS2 data sets that contain empty blocks (NULL chunks). This is something to handle carefully and needed for a work-arounds in WarpX BTD.
X-Refs.: