Fix meshName: Means mesh record #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix openPMD#167: do not introduce the name `meshName` if it is only used once and actually means "mesh record".
ax3l
added
the
revision change
RemiLehe
approved these changes
Jan 25, 2018
|
@DavidSagan since you reported #167, does this PR address it ok for you? :) |
DavidSagan
approved these changes
Jan 25, 2018
This was referenced Jan 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not introduce the name
meshNameif it is only used once and actually means "mesh record".Implements issue: #167
Description
In the base standard, the naming
meshNamewas unnecessarily introduced for a simple mesh record without using it later on.Affected Components
baseLogic Changes
None.
Writer Changes
No effects.
Reader Changes
No effects.
Data Converter
No effect, old files are forward compatible to this change.