-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheels: 0.16.0 #1677
Wheels: 0.16.0 #1677
Conversation
Update the cibuildwheel reference tracking to the 0.16.0 release.
fff6adb
to
4013c07
Compare
@franzpoeschel somehow, these wheels did neither pick up ADIOS2 nor HDF5... have to yank them from PyPI and redo. |
Ahh... WarpX CI runs on Python 3.8 and thus downloads the source file... will push 3.8 back in here |
There is another error in the built wheels that shows up in WarpX CI now:
This usually means there is a shared library or so not shipped in our all-static (at least we aim for that) Pip build. I am Yanked the 0.16.0 on PyPI now (latest again: 0.15.2 there) and we will fix this in 0.16.1. |
side note: Although no entirely trivial, we need to add a post-build selfcheck for wheels before we publish them in the scripts of the Will now do the post-mortem analysis so we can fix it in 0.16.1. |
I took a look at the buildlogs and I found our Python 3.8 build actually did build against Python 3.7, which is not compatible: Linux x86_64 build:
I am not sure how this happened yet, but we'll find out... 👀 |
I think this is from either the How we hint in This was based on https://cmake.org/cmake/help/v3.30/module/FindPython.html#artifacts-specification This was never a proper
|
I've seen this before when trying to make openPMD use a non-system Python. The best fix for that was always to use a virtualenv. |
Trying to check if this is truly only for superbuilds or also in pre-installed pybind versions: I think only superbuilds, I cannot find a link (direct or transitive) to |
Weird that it does not detect our use of |
The while `find_package(PythonInterp ...) inside FindPythonLibsNew.cmake is deprecated. I cannot even find how
Is pybind11 overwrititing the CMake stock FindPythonLibs.cmake...? And if so, why would it be used if we call the new |
Ok, so if we set Then pybind11 will call Well, not obvious from the docs, but ok. |
Fix developed in #1684 |
Reuse our `find_package(Python ...)` call and use new CMake logic in pybind11. https://pybind11.readthedocs.io/en/stable/compiling.html#modules-with-cmake https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-version-selection X-ref: openPMD/openPMD-api#1677 (comment) Signed-off-by: Axel Huebl <[email protected]>
Reuse our `find_package(Python ...)` call and use new CMake logic in pybind11. https://pybind11.readthedocs.io/en/stable/compiling.html#modules-with-cmake https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-version-selection X-ref: openPMD/openPMD-api#1677 (comment) Fix #5159 Signed-off-by: Axel Huebl <[email protected]>
Reuse our `find_package(Python ...)` call and use new CMake logic in pybind11. https://pybind11.readthedocs.io/en/stable/compiling.html#modules-with-cmake https://cmake.org/cmake/help/latest/command/find_package.html#config-mode-version-selection X-ref: openPMD/openPMD-api#1677 (comment) Fix ECP-WarpX#5159 Signed-off-by: Axel Huebl <[email protected]>
Update the cibuildwheel reference tracking to the 0.16.0 release.
setup.py
#Release notes: 0.16 #1648 (comment)