Non-spatial meshes #1534
Open
Non-spatial meshes #1534
+839
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be split into two parts at some point:
The first part might then also be relevant for other PRs where breaking changes are introduced (e.g. #1493 use of abbreviated attributes by default in JSON backend) EDIT: Done #1551 |
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
7a1760a
to
a6a8547
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
a6a8547
to
26b21aa
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
26b21aa
to
3948173
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
2 times, most recently
from
7534cb8
to
6d7513b
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
6d7513b
to
a244159
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
47c9d00
to
a9019f7
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
a9019f7
to
ffbd45a
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
3 times, most recently
from
d184a23
to
6045e89
Compare
franzpoeschel
commented
Mar 12, 2024
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
6045e89
to
fc9862b
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
2 times, most recently
from
da28b8c
to
12ed9bd
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
12ed9bd
to
bbc5c10
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
bbc5c10
to
2ff3cb5
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
f034d20
to
3b4255b
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
3b4255b
to
a57bc66
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
a57bc66
to
9965f6c
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
2 times, most recently
from
1e6bb68
to
227cb94
Compare
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
4fbdd31
to
92ef3ca
Compare
We cannot upgrade users silently in this place
for more information, see https://pre-commit.ci
1 task
franzpoeschel
force-pushed
the
non-spatial-meshes
branch
from
7d493a4
to
44decb6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| E = meshes["E"] | ||
| E.reset_dataset(io.Dataset(io.Datatype.DOUBLE, [10, 10, 10])) | ||
|
|
||
| def unsupported_in_1_1(): |
Check notice
Code scanning / CodeQL
Unused local variable Note test
|
I took a look over the PR and it seems okay to me. The interface fits for the binningPlugin use case. However the review isnt very thorough as I am unfamiliar with most of the code base and I don't know enough to follow some workflows. |
ikbuibui
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements openPMD/openPMD-standard#193
TODO: