Wheels: Fix macOS arm64 (M1) builds #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only built x64_64 targets so far for `arm64` and `universal2` builds for macOS. Setting now `CMAKE_OSX_ARCHITECTURES` to change that. https://cmake.org/cmake/help/latest/envvar/CMAKE_OSX_ARCHITECTURES.html?highlight=cmake_osx_architectures#envvar:CMAKE_OSX_ARCHITECTURES
ax3l
added
bug
affects latest release
frontend: Python3
continuous deployment
ax3l
commented
Mar 19, 2022
ax3l
commented
Mar 19, 2022
ax3l
commented
Mar 19, 2022
ax3l
force-pushed
the
fix-macos-arm-builds
branch
4 times, most recently
from
990a18f
to
b64e3b0
Compare
DILL patch not easy to apply yet.
ax3l
force-pushed
the
fix-macos-arm-builds
branch
from
b64e3b0
to
c657570
Compare
This provides the `arch` command.
ax3l
force-pushed
the
fix-macos-arm-builds
branch
from
c1f1a90
to
9be5403
Compare
ax3l
force-pushed
the
fix-macos-arm-builds
branch
from
9be5403
to
00cbb41
Compare
ax3l
force-pushed
the
fix-macos-arm-builds
branch
5 times, most recently
from
81bb03a
to
4ca8853
Compare
ax3l
changed the title
ax3l
force-pushed
the
fix-macos-arm-builds
branch
from
4ca8853
to
cdb09f0
Compare
ax3l
force-pushed
the
fix-macos-arm-builds
branch
11 times, most recently
from
bc458d7
to
c68dee3
Compare
Otherwise it might not be cross-compiled. Used in HDF5.
ax3l
force-pushed
the
fix-macos-arm-builds
branch
from
c68dee3
to
5a3d625
Compare
franzpoeschel
approved these changes
May 24, 2022
This was referenced Jun 7, 2022
Merged
ax3l
commented
Jul 26, 2022
|
|
||
| cmake -S dep-hdf5/hdf5-1.12.0 -B build-hdf5 ^ | ||
| cmake -S dep-hdf5/hdf5-1.12.2 -B build-hdf5 ^ |
There was a problem hiding this comment.
Forgot to update CIBW_ENVIRONMENT_WINDOWS which sets CMAKE_PREFIX_PATH in build.yml.
Fix in #1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only built x64_64 targets so far for
arm64builds for macOS.Setting now
CMAKE_OSX_ARCHITECTURESto change that.https://cmake.org/cmake/help/latest/envvar/CMAKE_OSX_ARCHITECTURES.html
Disable macOS
universal2builds because it's too cumbersome to build ADIOS1 and HDF5 twice and then combine them vialipoif we have two individual wheels anyway for now.Fix macOS
arm64builds, we can cross-compile HDF5 from macOSx86-64:Disable ADIOS1 on macOS
arm64, due to missing autotools support.Fix #1232