Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADIOS2 backend broken on post-2.5.0 master #586

Closed
franzpoeschel opened this issue Nov 7, 2019 · 0 comments · Fixed by #588
Closed

ADIOS2 backend broken on post-2.5.0 master #586

franzpoeschel opened this issue Nov 7, 2019 · 0 comments · Fixed by #588
Assignees
@franzpoeschel
Labels
backend: ADIOS2 bug

Comments

@franzpoeschel
Copy link
Contributor

franzpoeschel commented Nov 7, 2019 •
edited
Loading

PR #1821 breaks the ADIOS2 backend, see my comment there for an explanation.
I will shortly open PR with a temporary fix that reimplements the old prefix search, until I find the time for a more sensible solution (see the described solution in my comment) that makes use of the ADIOS2 PR.
@ax3l ax3l changed the title ADIOS2 backend broken with current Master of ADIOS2 ADIOS2 backend broken on post-2.5.0 master Nov 7, 2019
franzpoeschel added a commit to franzpoeschel/openPMD-api that referenced this issue Nov 8, 2019
@franzpoeschel
Temporarily workaround the changed behaviour of AvailableAttributes
80cdbc7 
To remove this workaround, create for each hierarchical group in the openPMD hierarchy a dummy variable so that prefixed AvailableAttributes will work again.
See openPMD#586 for further description.
@franzpoeschel franzpoeschel mentioned this issue Nov 8, 2019
Merged
franzpoeschel added a commit to franzpoeschel/openPMD-api that referenced this issue Nov 8, 2019
@franzpoeschel
Temporarily workaround the changed behaviour of AvailableAttributes
605f26e 
To remove this workaround, create for each hierarchical group in the openPMD hierarchy a dummy variable so that prefixed AvailableAttributes will work again.
See openPMD#586 for further description.
@ax3l ax3l closed this as completed in #588 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franzpoeschel franzpoeschel

Labels
backend: ADIOS2 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporary fix for "ADIOS2 backend broken on post-2.5.0 master" franzpoeschel/openPMD-api
2 participants
@ax3l @franzpoeschel