UBERON terms with 'nerve' in their name (part 1 of 2) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlrikeS91
added
the
request
43 tasks
|
EDIT (18.01.25): Split the PR into 2. Issue is not solved, just moved to #202. The check is failing because of typos in 2 files. One was a typo in the definition provided trough UBERON and I fixed it in our files ('teh' instead of 'the'). But I'm not sure how to solve the other one. The spellcheck reacts to 'opthalamic nerve' which is listed as a synonym for 'ophthalamic' (extra h between op and thalamic). Technically, the spellcheck is correct because it is not commonly used. What should we do? remove it from the list of synonyms or ignore the spell check? |
UlrikeS91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generation of terms is described in #133 and fully-automated (with minor clean-ups here and there)
Filtering:
any term with 'nerve' in name
Note: This is not to definitively group terms but to create smaller PRs with terms that are potentially related. Hopefully, this makes it easier to review but please do not request to remove terms because they do not fit into the grouping. Only consider whether or not they are suitable UBERONParcellations.