Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2D shapes to initial place #178

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

Peyman-N
Copy link
Member

@Peyman-N Peyman-N commented Mar 23, 2022

Adding 2D shapes to be stored in SANDS for the moment, as discussed in issue #8 of the ephys

@Peyman-N Peyman-N requested review from lzehl and UlrikeS91 March 23, 2022 16:04
@Peyman-N
Copy link
Member Author

For the moment, I have put them in miscellaneous folder, please let me know, where should I put them.

Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed together with @UlrikeS91

please put all of those schemas into a new folder:
schemas/mathematicalShapes/...

schemas/miscellaneous/circle.schema.tpl.json Outdated Show resolved Hide resolved
schemas/miscellaneous/ellipse.schema.tpl.json Outdated Show resolved Hide resolved
schemas/miscellaneous/ellipse.schema.tpl.json Outdated Show resolved Hide resolved
schemas/miscellaneous/ellipse.schema.tpl.json Outdated Show resolved Hide resolved
schemas/miscellaneous/rectangle.schema.tpl.json Outdated Show resolved Hide resolved
@lzehl lzehl merged commit 9564176 into openMetadataInitiative:v3 Aug 9, 2022
@Peyman-N Peyman-N deleted the Adding-2D-shapes branch August 12, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants