Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 3.0 had a hickup in the building (seems that schema extenstion did not work all the time) #18

Closed
lzehl opened this issue Jul 8, 2024 · 2 comments
Assignees

Comments

@lzehl
Copy link
Member

lzehl commented Jul 8, 2024

Stimulus -> EphysStimulus (but latter misses properties from first)

@olinux
Copy link
Member

olinux commented Jul 8, 2024

This is solved in the head (see commit openMetadataInitiative/openMINDS_stimulation@3916f02 ) and properly resolved in the "latest" (see https://github.com/openMetadataInitiative/openMINDS/blob/main/schemas/latest/stimulation/stimulus/ephysStimulus.schema.omi.json ) but the fixed version in https://github.com/openMetadataInitiative/openMINDS/blob/pipeline/versions.json still points to the previous commit. If you want this to be resolved for v3.0, you just have to update the commit hash in versions.json

@apdavison apdavison self-assigned this Oct 7, 2024
apdavison added a commit that referenced this issue Oct 7, 2024
lzehl added a commit that referenced this issue Oct 14, 2024
@lzehl
Copy link
Member Author

lzehl commented Oct 14, 2024

@apdavison thanks 👍 🙂

@lzehl lzehl closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants