Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[87] - Enhancements to Payment Hub Operations Web #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[87] - Enhancements to Payment Hub Operations Web #98

wants to merge 1 commit into from

Conversation

dipandhali2021
Copy link

Fixes: #87

User Management

  • Create users for 3 different roles (PH EE Admin, Govt Entity, FSP User)
  • Used Jbpm Service for User Request Workflow
  • View Update Delete User

Account Mapper

  • Filter Account Mapper Beneficiaries by logging different users

Visualization

  • Show the Keycloak Dashboard in Grafana

Payment Hub Batches, Sub-Batches and Transactions

  • Changed some columns and added Batch Summary

G2P Config

  • Shows configuration of govtId, fspId and Program

@DavidH-1
Copy link

DavidH-1 commented Sep 9, 2024

Is there an update to the readme.md file to reflect in this change. I couldn't see it.

@dipandhali2021
Copy link
Author

dipandhali2021 commented Sep 9, 2024 •
edited
Loading

Is there an update to the readme.md file to reflect in this change. I couldn't see it.

Can you please specify what should I write in the readme file?

alberto-art3ch
alberto-art3ch approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@alberto-art3ch alberto-art3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
Copy link
Contributor

@dipandhali2021 my suggestions:

  1. It is important to document in the readme, which is the defintion of the environment variables used in this enhacement.
  2. Enhacemnt, for an easy review must include some screenshots and instructions to replicate the enhacement.
  3. This is a huge contribution, I think that it can be splitted in individual PR related to the goals for a better review tracking. These are the goals of the issue [DMP 2024]: Enhancements to Payment Hub EE Operations Web UI #87
    [1] [Propose & Design UI/UX enhancements]
    [2] [Document as stories the outstanding UI screens to be implemented from Pay-BB Designs]
    [3] [Extend scope of Keycloak integration]
    [4] [Implement remaining UI screens identfied]
    [5] Implement usabilty enhancements
    [6] Integrate in the kibana/grafana dashboards and data visualizations.

IOhacker
IOhacker reviewed Sep 11, 2024
View reviewed changes
env.sample
@@ -7,6 +7,8 @@ export PH_VOU_CALLBACK_URL=https://webhook.site/

PH_ACT_BACKEND_SERVER_URL=https://paymenthub.qa.oneacrefund.org/opsapp/api/v1

export PH_G2P_PAYMENT_CONFIG_URL=https://gateway.mifos.community/v1.0/g2p-payment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variables to which backend service must point?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new service containing g2p configuration with operations like fetch govt entity, fsps , programs and g2p config.
Basically previously the g2p config was coming from a yaml file under budget account

https://github.com/openMF/ph-ee-bulk-processor/blob/9bf984fcf16105081ff53936f72405814ef8ba71/src/main/resources/application.yaml#L160-L161C1
So I have developed a new API as suggested by my mentor for it so we can configure it properly instead of changing the yaml file.

Currently it's working independently as a new service
In future we need to connect it with payment bulk processing

IOhacker
IOhacker reviewed Sep 11, 2024
View reviewed changes
env.sample
export PH_OAUTH_BASIC_AUTH=true

export PH_OAUTH_BASIC_AUTH_TOKEN=Y2xpZW50Og==

export PH_JBPM_API_URL=http://localhost:8180/kie-server/services/rest/server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is the helm chart that must be deployed to this endpoint? Why it is pointing to localhost instead of a DNS of the API Gateway?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the frontend we needed some tool for handling maker checker process of user creation so we have used a buisness process management called JBPM.

IOhacker
IOhacker reviewed Sep 11, 2024
View reviewed changes
env.sample

export PH_JBPM_CONTAINER_ID=PaymentHubEE_1.0.0-SNAPSHOT

export PH_JBPM_CREDENTIALS_ADMIN_MAKER=Y2xpZW50Og==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add instructions to create the secrets on K8s?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are environment variables required for using jbpm rest api services

IOhacker
IOhacker reviewed Sep 11, 2024
View reviewed changes
env.sample

export PH_JBPM_CREDENTIALS_ADMIN_MAKER=Y2xpZW50Og==

export PH_JBPM_CREDENTIALS_ADMIN_CHECKER=Y2xpZW50Og==
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add instructions to create the secrets on K8s?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipandhali2021 can you do this?

@DavidH-1
Copy link

did you also update the readme @dipandhali2021 ? it should indicate any changes needed as a result of the code and maybe even screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidH-1 DavidH-1 DavidH-1 left review comments

@IOhacker IOhacker IOhacker left review comments

@alberto-art3ch alberto-art3ch alberto-art3ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DMP 2024]: Enhancements to Payment Hub EE Operations Web UI
4 participants
@dipandhali2021 @DavidH-1 @IOhacker @alberto-art3ch