Change name to area_name #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened IAMconsortium/nomenclature#197 to address the currently failing tests. After this is merged we can check again if the tests run. |
danielhuppmann
approved these changes
Nov 15, 2022
|
Looks like there's a few gremlins left. I'll investigate further. |
|
Maybe a good idea for the future for any nomenclature unit/integration test would be to run against openENTRANCE. |
|
Looks like there's a few last issues to fix. I'm taking a look. |
|
Looks like it's all good now. @danielhuppmann, I'll go ahead with the merge to restore the service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the attribute
namein the region codelist filesnuts1.yaml,nuts2.yamlandnuts3.yamltoarea_name.An attribute named
namecauses issues with the latest nomenclature release.Running the tests, it seems we have another issue that will need to be fixed on the nomenclature side concerning multiple units.