Remove annotations of objects that are removed in Flattened archetype #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
============================================
+ Coverage 71.88% 71.91% +0.03%
- Complexity 7043 7054 +11
============================================
Files 670 670
Lines 22989 23008 +19
Branches 3729 3733 +4
============================================
+ Hits 16526 16547 +21
Misses 4717 4717
+ Partials 1746 1744 -2 ☔ View full report in Codecov by Sentry. |
MattijsK
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Flattener, objects with zero occurrences are removed (when the configuration says to do so). But the annotations belonging to those objects are not removed yet, resulting in a VRANP error.
Also removing the annotations when removing the objects will fix this error.