Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnotationDifferentiator #610

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

VeraPrinsen
Copy link
Collaborator

@VeraPrinsen VeraPrinsen commented Jul 2, 2024

Fixes #608

Differentiating archetypes does not yet differentiate the annotations, resulting in all annotations of the parents being in the child archetype.

With this AnnotationDifferentiator, the entries in the annotations that are also in the parent are now removed from the annotations in the child archetype.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.28%. Comparing base (e4d16b2) to head (3b70c11).
Report is 4 commits behind head on master.

Files Patch % Lines
...om/nedap/archie/diff/AnnotationDifferentiator.java 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
+ Coverage     71.85%   72.28%   +0.43%     
- Complexity     6972     7229     +257     
============================================
  Files           663      671       +8     
  Lines         22740    23449     +709     
  Branches       3680     3905     +225     
============================================
+ Hits          16340    16951     +611     
- Misses         4669     4725      +56     
- Partials       1731     1773      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VeraPrinsen VeraPrinsen requested a review from MattijsK July 2, 2024 07:04
Copy link
Collaborator

@MattijsK MattijsK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@VeraPrinsen VeraPrinsen merged commit bef8f81 into master Aug 7, 2024
4 checks passed
@VeraPrinsen VeraPrinsen deleted the 608_annotation_differentiator branch August 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnotationDifferentiator
3 participants