Replaced np.int with int in adaptive_coarsegrain #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy.int was an alias for Python's built-in int function that was removed from NumPy in version 1.24. Updated this so that the adaptive coarsegraining can be performed while using NumPy >= 1.24
Replaced np.int with int in adaptive_coarsegrain
|
Thank you @gschuette ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adaptive_coarsegrain function doesn't work when using NumPy 1.24 and later because line 1318 in cooltools/cooltools/lib/numutils.py uses
np.int, which was deprecated in NumPy 1.20 and fully removed in NumPy 1.24 (see here). It should be replaced byintornp.int_.Per the suggestion from @nvictus in issue 472, I opted for the
intoption.