Fix incorrect variance returned by _balance_cisonly #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, _balance_cisonly returns the variance for the last chromosome that was processed. This commit updates _balance_cisonly to return variances for each chromosome. Note that this affects the HDF5 type of attributes "var" and "converged".
robomics
added a commit
to paulsengroup/2022-mcf10a-cancer-progression
that referenced
this pull request
Feb 9, 2023
robomics
added a commit
to paulsengroup/2022-mcf10a-cancer-progression
that referenced
this pull request
Feb 9, 2023
robomics
added a commit
to paulsengroup/2022-mcf10a-cancer-progression
that referenced
this pull request
Feb 9, 2023
|
Thank you. Great catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that causes
_balance_cisonlyto return the variance for the last chromosome that was processed instead of the variance for each individual chromosome.Note that this affects the HDF5 type of attributes "var" and "converged" stored in the
weightdataset.