cols and df_view_col passed to downstream functions

[smitkadvani]

• cols and df_view_cols passed to downstream functions.
• Running following example returns True and doesn't break

import bioframe as bf
import pandas as pd

cols = ['chrom', 'start', 'end']
data = [
    ('chr1', 1000000, 1250000),
    ('chr1', 1500000, 1750000),
    ('chr2', 1000000, 1300000),
    ('chr2', 2000000, 2300000)
]
df = pd.DataFrame(data, columns=cols)

# Create a sample DataFrame
view_cols = ['CHROM', 'START', 'END']
data = [
    ('chr1', 1000000, 1250000),
    ('chr1', 1500000, 1750000),
    ('chr2', 1000000, 1300000),
    ('chr2', 2000000, 2300000)
]
view_df = pd.DataFrame(data, columns=view_cols)

bf.is_contained(df, view_df, cols=cols, view_cols=view_cols)

[gfudenberg]

thanks for the fix @smitkadvani !

Does the above still work if the view_df has a column "name", e.g.

bioframe/tests/test_core_checks.py

Line 71 in 933c92b

columns=["chrom", "start", "end", "name"],

It would be great to modify the above code example and include it as a test

bioframe/tests/test_core_checks.py

Line 63 in 933c92b

def test_is_contained():

(or modify one of the existing tests to have a df & view_df with non-conventional column names)

We should also add the case of nonstandard df_view_col and view_name_col (e.g. view_name_col="NAME" and df_view_col="VIEWREGION") to tests.

For consistency it also looks like next few functions in checks could use view_cols to support non-default names for those as well (is_covering, is_tiling, and is_sorted)-- this would be great to address in same PR!

[gfudenberg]

great!