Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mark_runs and compress_runs #164

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Conversation

nvictus
Copy link
Member

@nvictus nvictus commented Jun 20, 2023

I personally use this all the time. Figured it's finally time to add it.

@nvictus nvictus requested review from gfudenberg and gspracklin June 20, 2023 23:45
@nvictus nvictus force-pushed the feat-mark-compress-runs branch 3 times, most recently from 8176598 to 76354f2 Compare June 21, 2023 02:00
@nvictus
Copy link
Member Author

nvictus commented Jun 21, 2023

Question: which name do we like better, compress_runs or merge_runs?

It basically very similar to merge, but instead of combining all intervals which transitively overlap (thus, sharing a unique cluster ID), it takes the hull of intervals that are (1) back-to-back and (2) share a value in a column (thus, sharing a unique run ID).

@nvictus nvictus requested a review from golobor June 21, 2023 02:04
@nvictus nvictus force-pushed the feat-mark-compress-runs branch from 76354f2 to 023f2ad Compare June 21, 2023 02:10
@nvictus
Copy link
Member Author

nvictus commented Jun 21, 2023

Now I'm wondering if these couldn't just be special cases of cluster and merge.

@nvictus nvictus force-pushed the feat-mark-compress-runs branch from 7c41165 to 10d8384 Compare June 21, 2023 23:15
bioframe/extras.py Show resolved Hide resolved
@nvictus nvictus merged commit 6515f1c into open2c:main Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants