Fix problem with overlap indexes data types (where returned as float)

open2c · Feb 6, 2024 · e7d4c1c · e7d4c1c
1 parent bfac0e1
commit e7d4c1c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/bioframe/extras.py b/bioframe/extras.py
@@ -513,9 +513,7 @@ def pair_by_distance(
     idxs["intervening"] = (
         np.abs(idxs[f"index{suffixes[0]}"] - idxs[f"index{suffixes[1]}"]) - 1
     )
-    idxs = idxs.query(
-        f"intervening<={max_intervening} and intervening>={min_intervening}"
-    )
+    idxs = idxs[(idxs['intervening']<=max_intervening) & (idxs['intervening']>=min_intervening)]
 
     left_ivals = (
         df.iloc[idxs[f"index{suffixes[0]}"].values]

diff --git a/bioframe/ops.py b/bioframe/ops.py
@@ -511,8 +511,8 @@ def overlap(
     index_col = return_index if isinstance(return_index, str) else "index"
     index_col_1 = index_col + suffixes[0]
     index_col_2 = index_col + suffixes[1]
-    df_index_1 = pd.DataFrame({index_col_1: df1.index[events1]})
-    df_index_2 = pd.DataFrame({index_col_2: df2.index[events2]})
+    df_index_1 = pd.DataFrame({index_col_1: df1.index[events1]}, dtype=pd.Int64Dtype())
+    df_index_2 = pd.DataFrame({index_col_2: df2.index[events2]}, dtype=pd.Int64Dtype())
 
     df_overlap = None
     if return_overlap: