Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bound asset metadata strings #949

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

gregdhill
Copy link
Contributor

Use BoundedVec for name and symbol in AssetMetadata so we can derive MaxEncodedLen and remove without_storage_info on the pallet.

Signed-off-by: Gregory Hill <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #949 (5e2183a) into master (7582d37) will increase coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   78.40%   78.44%   +0.03%     
==========================================
  Files         105      105              
  Lines       10782    10796      +14     
==========================================
+ Hits         8454     8469      +15     
+ Misses       2328     2327       -1     
Files Changed Coverage Δ
asset-registry/src/impls.rs 52.11% <0.00%> (+0.72%) ⬆️
asset-registry/src/lib.rs 89.53% <ø> (ø)
asset-registry/src/mock/para.rs 70.73% <ø> (ø)
traits/src/asset_registry.rs 100.00% <ø> (ø)
asset-registry/src/mock/mod.rs 78.57% <100.00%> (ø)
asset-registry/src/tests.rs 98.00% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xlc xlc merged commit 7e15fcf into open-web3-stack:master Aug 29, 2023
5 checks passed
@gregdhill gregdhill deleted the bounded-string branch August 29, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants