prevent nested DelayedOrigin #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 78.79% 78.85% +0.06%
==========================================
Files 102 102
Lines 10515 10546 +31
==========================================
+ Hits 8285 8316 +31
Misses 2230 2230
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xlc
force-pushed
the
handle-delayed-origin
branch
from
aa18409
to
a93caac
Compare
zjb0807
reviewed
Nov 21, 2022
Co-authored-by: zjb0807 <[email protected]>
shaunxw
approved these changes
Nov 21, 2022
zjb0807
added a commit
that referenced
this pull request
Nov 22, 2022
* prevent nested DelayedOrigin * fix deps * Update authority/src/tests.rs Co-authored-by: zjb0807 <[email protected]> * allow nested DelayedOrigin * update docstring * typo fix Co-authored-by: zjb0807 <[email protected]>
Merged
zjb0807
added a commit
that referenced
this pull request
Nov 22, 2022
* claim_rewards should not create empty records (#835) * refactor: make weight argument in xtokens transfers optional (#841) * refactor: make weight argument in xtokens be of type WeightLimit * refactor: rename dest_weight -> dest_weight_limit * prevent nested DelayedOrigin (#845) * prevent nested DelayedOrigin * fix deps * Update authority/src/tests.rs Co-authored-by: zjb0807 <[email protected]> * allow nested DelayedOrigin * update docstring * typo fix Co-authored-by: zjb0807 <[email protected]> * Add try-runtime feature for orml-payments (#846) * Add try-runtime feature for orml-payments * Add features Co-authored-by: wangjj9219 <[email protected]> Co-authored-by: sander2 <[email protected]> Co-authored-by: Xiliang Chen <[email protected]>
devdanco
added a commit
to gasp-xyz/open-runtime-module-library
that referenced
this pull request
Feb 14, 2023
* run CI for release branch * Upgrade polkadot-v0.9.31 (open-web3-stack#830) * Upgrade polkadot-v0.9.31 * Update authority/src/lib.rs Co-authored-by: Xiliang Chen <[email protected]> * fix tests Co-authored-by: Xiliang Chen <[email protected]> * add CODECOV_TOKEN (open-web3-stack#836) * claim_rewards should not create empty records (open-web3-stack#835) * Update Readme (open-web3-stack#837) * Update Readme Plasm Network rebranded last year to Astar Network Source: https://medium.com/astar-network/plasm-rebrands-to-astar-network-in-pursuit-of-becoming-a-polkadot-native-dapp-hub-6db3121c4f13 * Update README.md Change order * Token hook refactoring; Posthooks for deposit and transfer (open-web3-stack#834) * feat(tokens): Refactor hooks into single trait * feat(tokens): Add post-hooks for Transfer and Deposit * chore(tokens): improve mutation hook naming * fix(tokens): PostDeposit hook (open-web3-stack#839) * fix(tokens): PostDeposit hook * test(tokens): posthook correctness * fix(tokens): use `assert` instead of `ensure` in mock posthooks * Add Centrifuge to users of orml (open-web3-stack#842) * Add Crust to ORML (open-web3-stack#843) * refactor: make weight argument in xtokens transfers optional (open-web3-stack#841) * refactor: make weight argument in xtokens be of type WeightLimit * refactor: rename dest_weight -> dest_weight_limit * Update weight-gen template.hbs (open-web3-stack#844) * prevent nested DelayedOrigin (open-web3-stack#845) * prevent nested DelayedOrigin * fix deps * Update authority/src/tests.rs Co-authored-by: zjb0807 <[email protected]> * allow nested DelayedOrigin * update docstring * typo fix Co-authored-by: zjb0807 <[email protected]> * Add try-runtime feature for orml-payments (open-web3-stack#846) * Add try-runtime feature for orml-payments * Add features * Update to Polkadot v0.9.32 (open-web3-stack#848) * Add new for DelayedOrigin (open-web3-stack#849) * Update README.md (open-web3-stack#851) * Update README.md Update modules description * Update README.md Further updates on description. * #xcm polishing #xtokens README.md (open-web3-stack#856) * Update github actions (open-web3-stack#855) * Update github actions * trigger GitHub actions * Changed `vested_transfer` extrinsic behavior. (open-web3-stack#857) * Changed `vested_transfer` extrinsic behavior. Fixed self-vesting case (`from` == `to`) when it was possible to self-freeze funds above the current account balance. * added test for self-vesting case * Upgrade polkadot-v0.9.33 (open-web3-stack#858) * use explicit call index (open-web3-stack#865) * Upgrade to polkadot v0.9.36 (open-web3-stack#864) * build: upgrade to polkadot v0.9.36 Signed-off-by: Yaroslav Bolyukin <[email protected]> * style: fix formatting Signed-off-by: Yaroslav Bolyukin <[email protected]> * fix: polkadot dependency references Signed-off-by: Yaroslav Bolyukin <[email protected]> * build: use released cumulus Signed-off-by: Yaroslav Bolyukin <[email protected]> * fix: make asset_exists return false Signed-off-by: Yaroslav Bolyukin <[email protected]> Signed-off-by: Yaroslav Bolyukin <[email protected]> * update asset_exists (open-web3-stack#866) * fix test * Update polkadot v0.9.36 (open-web3-stack#878) * Fix payments on-idle (open-web3-stack#868) * fix payments on-idle * update comment * Switch to Rust-1.66 (open-web3-stack#869) * feat: derive MEL for Value enum (open-web3-stack#867) * feat: impl MEL for Value enum * fmt: fix * feat:Make the XcmTransfer trait support transfer_multiasset_with_fee (open-web3-stack#870) * update bencher deps (open-web3-stack#872) * add BenchmarkError::Weightless (open-web3-stack#873) * add BenchmarkError::Weightless * Update benchmarking/src/lib.rs Co-authored-by: zjb0807 <[email protected]> Co-authored-by: zjb0807 <[email protected]> * Update jsonrpsee 0.16.2 (open-web3-stack#876) * Update jsonrpsee 0.16.2 * fix clippy * fix clippy Co-authored-by: William Freudenberger <[email protected]> Co-authored-by: NingBo Wang <[email protected]> Co-authored-by: Ermal Kaleci <[email protected]> Co-authored-by: Andrew Plaza <[email protected]> * update packages * update reference --------- Signed-off-by: Yaroslav Bolyukin <[email protected]> Co-authored-by: Bryan Chen <[email protected]> Co-authored-by: zjb0807 <[email protected]> Co-authored-by: wangjj9219 <[email protected]> Co-authored-by: Maarten <[email protected]> Co-authored-by: Daniel Savu <[email protected]> Co-authored-by: Miguel Hervas <[email protected]> Co-authored-by: Myron <[email protected]> Co-authored-by: sander2 <[email protected]> Co-authored-by: Nuno Alexandre <[email protected]> Co-authored-by: Lawrence Law - Acala <[email protected]> Co-authored-by: Dzmitry Lahoda <[email protected]> Co-authored-by: Pavel Orlov <[email protected]> Co-authored-by: Daniel Shiposha <[email protected]> Co-authored-by: Yaroslav Bolyukin <[email protected]> Co-authored-by: William Freudenberger <[email protected]> Co-authored-by: NingBo Wang <[email protected]> Co-authored-by: Ermal Kaleci <[email protected]> Co-authored-by: Andrew Plaza <[email protected]>
devdanco
added a commit
to gasp-xyz/open-runtime-module-library
that referenced
this pull request
May 25, 2023
* run CI for release branch * Upgrade polkadot-v0.9.31 (open-web3-stack#830) * Upgrade polkadot-v0.9.31 * Update authority/src/lib.rs Co-authored-by: Xiliang Chen <[email protected]> * fix tests Co-authored-by: Xiliang Chen <[email protected]> * add CODECOV_TOKEN (open-web3-stack#836) * claim_rewards should not create empty records (open-web3-stack#835) * Update Readme (open-web3-stack#837) * Update Readme Plasm Network rebranded last year to Astar Network Source: https://medium.com/astar-network/plasm-rebrands-to-astar-network-in-pursuit-of-becoming-a-polkadot-native-dapp-hub-6db3121c4f13 * Update README.md Change order * Token hook refactoring; Posthooks for deposit and transfer (open-web3-stack#834) * feat(tokens): Refactor hooks into single trait * feat(tokens): Add post-hooks for Transfer and Deposit * chore(tokens): improve mutation hook naming * fix(tokens): PostDeposit hook (open-web3-stack#839) * fix(tokens): PostDeposit hook * test(tokens): posthook correctness * fix(tokens): use `assert` instead of `ensure` in mock posthooks * Add Centrifuge to users of orml (open-web3-stack#842) * Add Crust to ORML (open-web3-stack#843) * refactor: make weight argument in xtokens transfers optional (open-web3-stack#841) * refactor: make weight argument in xtokens be of type WeightLimit * refactor: rename dest_weight -> dest_weight_limit * Update weight-gen template.hbs (open-web3-stack#844) * prevent nested DelayedOrigin (open-web3-stack#845) * prevent nested DelayedOrigin * fix deps * Update authority/src/tests.rs Co-authored-by: zjb0807 <[email protected]> * allow nested DelayedOrigin * update docstring * typo fix Co-authored-by: zjb0807 <[email protected]> * Add try-runtime feature for orml-payments (open-web3-stack#846) * Add try-runtime feature for orml-payments * Add features * Update to Polkadot v0.9.32 (open-web3-stack#848) * Add new for DelayedOrigin (open-web3-stack#849) * Update README.md (open-web3-stack#851) * Update README.md Update modules description * Update README.md Further updates on description. * #xcm polishing #xtokens README.md (open-web3-stack#856) * Update github actions (open-web3-stack#855) * Update github actions * trigger GitHub actions * Changed `vested_transfer` extrinsic behavior. (open-web3-stack#857) * Changed `vested_transfer` extrinsic behavior. Fixed self-vesting case (`from` == `to`) when it was possible to self-freeze funds above the current account balance. * added test for self-vesting case * Upgrade polkadot-v0.9.33 (open-web3-stack#858) * use explicit call index (open-web3-stack#865) * Upgrade to polkadot v0.9.36 (open-web3-stack#864) * build: upgrade to polkadot v0.9.36 Signed-off-by: Yaroslav Bolyukin <[email protected]> * style: fix formatting Signed-off-by: Yaroslav Bolyukin <[email protected]> * fix: polkadot dependency references Signed-off-by: Yaroslav Bolyukin <[email protected]> * build: use released cumulus Signed-off-by: Yaroslav Bolyukin <[email protected]> * fix: make asset_exists return false Signed-off-by: Yaroslav Bolyukin <[email protected]> Signed-off-by: Yaroslav Bolyukin <[email protected]> * update asset_exists (open-web3-stack#866) * Fix payments on-idle (open-web3-stack#868) * fix payments on-idle * update comment * Switch to Rust-1.66 (open-web3-stack#869) * feat: derive MEL for Value enum (open-web3-stack#867) * feat: impl MEL for Value enum * fmt: fix * feat:Make the XcmTransfer trait support transfer_multiasset_with_fee (open-web3-stack#870) * update bencher deps (open-web3-stack#872) * add BenchmarkError::Weightless (open-web3-stack#873) * add BenchmarkError::Weightless * Update benchmarking/src/lib.rs Co-authored-by: zjb0807 <[email protected]> Co-authored-by: zjb0807 <[email protected]> * Update jsonrpsee 0.16.2 (open-web3-stack#876) * Update jsonrpsee 0.16.2 * fix clippy * fix clippy * Update README.md (open-web3-stack#879) Added Mangata and Parallel Finance * Update README.md (open-web3-stack#880) Added Moonbeam * Upgrade polkadot-v0.9.37 (open-web3-stack#882) * Add lock events to tokens pallet (open-web3-stack#883) * Implement lock events in update_locks(...) * Implement lock tests * Replace depracted clippy rule name * Move tests into correct test file * Use correct Event type * Update xtokens docs (open-web3-stack#885) * added ajuna network (open-web3-stack#887) using mainly the orml-vesting ... * Upgrade polkadot-v0.9.38 (open-web3-stack#886) * Upgrade polkadot-v0.9.38 * use `as_bounded_slice` * `latest` instead explicit version * use `AllCounted` for asset deposit * Update `asset-registry` tests * Update `benchmarking` tests * Update `traits` tests * Update `unknown-tokens` tests * Update `xcm-support` tests * Update `xtokens` tests * Update `Cargo.dev.toml` pin * clippy * Specific version instead `latest` * Add test `MultiLocation` encoding * Remove `sp-authorship` * Update `sp-weights` pin * Fix runtime-benchmarks * Add `asset-registry` migration * clippy * Assert `StorageVersion` * Assert multiple migration calls * AddImpl `OnRuntimeUpgrade` * Add `unknown-tokens` migration * Use xcm::v3 instead of latest (open-web3-stack#889) * max weight fix (open-web3-stack#891) * XcmTransfer Trait (open-web3-stack#892) * Add more methods on XcmTransfer trait * Add Transferred for XcmTransfer * fix tests * fix clippy * fix migration and tests (open-web3-stack#893) * build: upgrade polkadot to v0.9.39 (open-web3-stack#897) * Add & clean deprecated (open-web3-stack#895) * clean deprecated * add dependencies on RPC * add deprecated on RPC * fix clippy * remove tests * Expose Xtokens pallet weight (open-web3-stack#898) * fix unknown-tokens migration (open-web3-stack#899) * fix unknown-tokens migration * remove debug print * Upgrade polkadot to v0.9.40 (open-web3-stack#902) * Upgrade polkadot to v0.9.40 * add import for Hasher * replace from_ref_time to from_parts * fix CI * remove unnecessary workspace word * update branch ref --------- Signed-off-by: Yaroslav Bolyukin <[email protected]> Co-authored-by: Bryan Chen <[email protected]> Co-authored-by: zjb0807 <[email protected]> Co-authored-by: wangjj9219 <[email protected]> Co-authored-by: Maarten <[email protected]> Co-authored-by: Daniel Savu <[email protected]> Co-authored-by: Miguel Hervas <[email protected]> Co-authored-by: Myron <[email protected]> Co-authored-by: sander2 <[email protected]> Co-authored-by: Nuno Alexandre <[email protected]> Co-authored-by: Lawrence Law - Acala <[email protected]> Co-authored-by: Dzmitry Lahoda <[email protected]> Co-authored-by: Pavel Orlov <[email protected]> Co-authored-by: Daniel Shiposha <[email protected]> Co-authored-by: Yaroslav Bolyukin <[email protected]> Co-authored-by: William Freudenberger <[email protected]> Co-authored-by: NingBo Wang <[email protected]> Co-authored-by: Ermal Kaleci <[email protected]> Co-authored-by: Andrew Plaza <[email protected]> Co-authored-by: Joshua Cheong <[email protected]> Co-authored-by: Harald Heckmann <[email protected]> Co-authored-by: Cedric Decoster <[email protected]> Co-authored-by: tgmichel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://substrate.stackexchange.com/questions/5970/implement-maxencodedlen-for-nested-origin
One issue is that this make decode invalid but it is still possible to construct nested DelayedOrigin normally.
This means the storage will be inconsistent if someone is ever successfully wrote origin containing nested DelayedOrigin. The read will fail.
Maybe the safer way is not making decoding nested DelayedOrigin invalid. Just guarded enough so ensure it cannot be constructed but even it does, it is not a state consistency error but just a PoV size estimation issue.