-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot v1.12.0 #1003
polkadot v1.12.0 #1003
Conversation
Please update https://github.com/open-web3-stack/open-runtime-module-library/blob/master/Cargo.dev.toml to use polkadot-sdk v1.12.0 |
Ah damn, forgot to commit this because it was in the Cargo.toml only. Fixed it now. I could have noticed this earlier if the CI ran. I am wondering: as this isn't my first contribution, and neither my last. Is it possible to make the CI run with my PRs automatically? |
I see that the coverage workflow failed due to the rate limit. Can we merge it like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This should be a GitHub setting. But it seems to run automatically.
The coverage is not required. It's fine. |
Alright I see. I thought that I read that it needs a maintainer to run the action. Cool, thanks a lot! |
* [tokens] update fungible implementation * [benchmarking] update benchmarks * [asset-registry] add `XcmRecorder` associated type to mocks * [tokens] add preservation arg to tests * [xtokens] add `XcmRecorder` associated type to mocks * fmt * [benchmarking] fix tests * add updated Cargo.dev.toml
Noteworthy changes
Preservation
arg to burn function in fungible traitXcmRecorder
toXcmConfig
for mocksI would be very happy if this is released soon on crates.io ;)