Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the script if a command fails #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

othomann
Copy link
Contributor

This is based on user experience. One user forgot to add the IBM_CLOUD_API_KEY and the script continues to run even if the docker image was never built.

@maire-kehoe
Copy link
Contributor

Note, we need to follow the updated process for changes to this repo, that is, not creating PRs here.

@gmarjoram gmarjoram requested review from gmarjoram and removed request for gmarjoram September 16, 2021 10:33
@maire-kehoe
Copy link
Contributor

Note this change is on master, in the commit:

  • Update build_image_buildkit.sh
    20c8bdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants