Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute registry location is now an argument to markdown update #76

Merged

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Apr 2, 2024

This is the next step in a "demo" for moving markdown generation from build-tools to weaver for semantic-conventions repository.

  • Add new attribute registry url parameter
  • Update legacy tests to look more similar to build-tools using this parameter.

jsuereth added 3 commits April 1, 2024 12:49
When updating markdown, allow attribute registry links to be specified via command line argument.
We removed mandaotry attribute registry links, so the legacy test now doesn't force attribute registry.
@jsuereth
Copy link
Contributor Author

jsuereth commented Apr 2, 2024

@lquerel My PRs keep seeing a clippy failure of:

error: field `type_mapping` is never read
  --> crates/weaver_forge/src/config.rs:59:9
   |
41 | pub struct TargetConfig {
   |            ------------ field in this struct
...
59 |     pub type_mapping: HashMap<String, String>,
   |         ^^^^^^^^^^^^
   |
   = note: `TargetConfig` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

Even though I haven't touched this code at all. Can I just add allow dead_code or do you have some other fix in place for this?

@jsuereth jsuereth marked this pull request as ready for review April 2, 2024 12:54
@jsuereth jsuereth requested a review from lquerel as a code owner April 2, 2024 12:54
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit bc9555a into open-telemetry:main Apr 2, 2024
13 checks passed
@jsuereth jsuereth deleted the pr-attribute-registry-parameter branch April 2, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants