Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent newline behavior #509

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

trask
Copy link
Member

@trask trask commented Dec 6, 2024

This seemed like a good change independently, but also builds towards the fix in #511

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.0%. Comparing base (c5c66ba) to head (609f13c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_forge/src/formats/html.rs 88.8% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #509   +/-   ##
=====================================
  Coverage   73.9%   74.0%           
=====================================
  Files         50      50           
  Lines       3911    3916    +5     
=====================================
+ Hits        2894    2899    +5     
  Misses      1017    1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask marked this pull request as ready for review December 6, 2024 03:46
@trask trask requested a review from a team as a code owner December 6, 2024 03:46
@jsuereth jsuereth merged commit d88b75f into open-telemetry:main Dec 6, 2024
23 checks passed
@trask trask deleted the newlines branch December 6, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants