Fix #345 - Build ARM64 image. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lquerel It looks like building both in test takes a really long time. Do we think it's worth having the previous test-image build we had and assuming building for ARM in docker will succeed on release or should we perform it in every pull request? |
|
Oof - so here' s an alternative: https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners Take a look and let me know what you think - I'll look into the more complicated setup a bit later. |
|
I updated this so the combined image is only created on release for now. |
lquerel
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the docker guide for setting up QEMU to build an ARM + x86 image.
Fixes #345
Note: This may not be the fastest way to do these builds, it's just the most convenient.