Add Jinja whitespace control #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
weird sometimes the test fails also on my machine for the line end of the file. I will look into it |
lquerel
requested changes
Jun 27, 2024
lquerel
approved these changes
Jun 28, 2024
trisch-me
reviewed
Jun 28, 2024
|
If I got it right, I don't need the defaults annotations and functions, and I also removed the constructor. Sorry still very noob in Rust :D. Hope it is alright now. |
trisch-me
approved these changes
Jun 28, 2024
|
Not sure why the build is stuck? 🤔. I don't have permission to retry it. |
|
it's not stuck, I think it's because your test has failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220
I added the new properties to the existing struct
TemplateSyntaxbut I'm not so convinced that's the best place. I can see how it makes sense as the "Jinja config things" but 🤔. I'm open to suggestions. Maybe a different struct to configure jinja environment "in general"? Or maybe renameTemplateSyntaxto something else, so it not only contain syntax things but general Jinja settings?