-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Embed option for single attributes #212
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
+ Coverage 73.5% 74.2% +0.7%
=======================================
Files 45 44 -1
Lines 2983 2960 -23
=======================================
+ Hits 2194 2199 +5
+ Misses 789 761 -28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@trisch-me could you update your PR with the last main branch so we could include this PR in the next release. Thanks |
@lquerel I have updated and added tests. local coverage shows me 68%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Adds embedded option for specific attribute (first part of open-telemetry/build-tools#240)