Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Embed option for single attributes #212

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Conversation

trisch-me
Copy link
Contributor

@trisch-me trisch-me commented Jun 13, 2024

Adds embedded option for specific attribute (first part of open-telemetry/build-tools#240)

@trisch-me trisch-me marked this pull request as draft June 13, 2024 19:09
@lquerel lquerel added the enhancement New feature or request label Jun 13, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.2%. Comparing base (77d0d9b) to head (ca71137).

Current head ca71137 differs from pull request most recent head f489b30

Please upload reports for the commit f489b30 to get more accurate results.

Files Patch % Lines
crates/weaver_resolver/src/attribute.rs 53.8% 6 Missing ⚠️
crates/weaver_resolved_schema/src/lineage.rs 50.0% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #212     +/-   ##
=======================================
+ Coverage   73.5%   74.2%   +0.7%     
=======================================
  Files         45      44      -1     
  Lines       2983    2960     -23     
=======================================
+ Hits        2194    2199      +5     
+ Misses       789     761     -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trisch-me trisch-me marked this pull request as ready for review June 21, 2024 12:47
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel
Copy link
Contributor

lquerel commented Jun 26, 2024

@trisch-me could you update your PR with the last main branch so we could include this PR in the next release. Thanks

@trisch-me
Copy link
Contributor Author

@lquerel I have updated and added tests. local coverage shows me 68%.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lquerel lquerel merged commit 98fe349 into open-telemetry:main Jun 28, 2024
22 checks passed
@trisch-me trisch-me changed the title Embed for attributes Add Embed option for single attributes Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants