Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) First cut at a developer's guide to help onboarding users. #166

Merged
merged 3 commits into from
May 20, 2024

Conversation

jsuereth
Copy link
Contributor

Adds just a few tips & tricks from my own experience working on semconv. Would like to keep this up-to-date as we finish up policy engine and move beyond just semconv.

@jsuereth jsuereth requested a review from lquerel as a code owner May 20, 2024 13:55
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2%. Comparing base (4401e3d) to head (0202aab).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #166   +/-   ##
=====================================
  Coverage   75.2%   75.2%           
=====================================
  Files         45      45           
  Lines       2704    2704           
=====================================
  Hits        2034    2034           
  Misses       670     670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made few suggestions.

docs/developer-guide.md Outdated Show resolved Hide resolved
docs/developer-guide.md Outdated Show resolved Hide resolved
docs/developer-guide.md Show resolved Hide resolved
@jsuereth jsuereth merged commit b1e8588 into open-telemetry:main May 20, 2024
17 checks passed
@jsuereth jsuereth deleted the wip-guide branch May 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants