Additional filters and tests #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
reviewed
May 17, 2024
Filters: - `instantiated_type`: Filters a type to return the instantiated type. - `enum_type`: Filters a type to return the enum type or an error if the type is not an enum. Tests: - `enum`: Tests if an attribute has an enum type. - `simple_type`: Tests if a type is a simple type (i.e.: string | string[] | int | int[] | double | double[] | boolean | boolean[]). - `template_type`: Tests if a type is a template type (i.e.: template[]). - `enum_type`: Tests if a type is an enum type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
=======================================
+ Coverage 74.7% 75.2% +0.4%
=======================================
Files 45 45
Lines 2627 2704 +77
=======================================
+ Hits 1963 2034 +71
- Misses 664 670 +6 ☔ View full report in Codecov by Sentry. |
jsuereth
approved these changes
May 17, 2024
| if current_inferred_type != member_type { | ||
| // If the inferred type is different from the member type, then the enum | ||
| // type is "promoted" to a string. | ||
| Some("string".to_owned()) |
There was a problem hiding this comment.
I believe this is the right way to go... We may need to improve enum in the model so type is actually specified AND enforced on members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds/updates the following filters:
instantiated_type: Filters a type to return the instantiated type.enum_type: Filters a type to return the enum type or an error if the type is not an enum.capitalize_first: Capitalizes the first letter of a string.map_textintroduces a second parameter to define the default value if the name of the text map or the input are not found in thetext_mapssection (optional parameter).This PR adds the following tests:
enum: Tests if an attribute has an enum type.simple_type: Tests if a type is a simple type (i.e.: string | string[] | int | int[] | double | double[] | boolean | boolean[]).template_type: Tests if a type is a template type (i.e.: template[]).enum_type: Tests if a type is an enum type.Documentation has been updated.
Unit tests have been created.