Skip to content

Commit

Permalink
Update the semconv::test_semconv_spec_from_url test to use an invalid…
Browse files Browse the repository at this point in the history
… domain
  • Loading branch information
MSNev committed Aug 12, 2024
1 parent 9861ce0 commit c9c9738
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/weaver_semconv/src/semconv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ mod tests {
InvalidSemConvSpec { .. }
));

// Non-existing URL
let semconv_url = "http://unknown.com/unknown-semconv.yaml";
// Non-existing URL (including both a leading underscore (which is not a valid domain) and a non-existing domain)
let semconv_url = "http://_unknown.com.invalid/unknown-semconv.yaml";
let semconv_spec = SemConvSpec::from_url(semconv_url);
assert!(semconv_spec.is_err());
assert!(matches!(semconv_spec.unwrap_err(), RegistryNotFound { .. }));
Expand Down

0 comments on commit c9c9738

Please sign in to comment.