-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Attribute Registry using Weaver #917
Generate Attribute Registry using Weaver #917
Conversation
Relies on (not submitted yet) flatten filter in weaver
- Update notes macros to be a library for re-use - Update attribute registry so deprecated yaml consistently use prefix - Add Deprecated rendering markdwon - Update config to extract deprecated attributes in registry.
…aver-snippet-gen check.
@jsuereth looks like unrelated changed in the |
@nirga What are you seeing that's not related? As part of this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is ready for review. Upon enough acceptance, a weaver version will be cut with all necessary functionality so and this PR will be updated to only use this version.
How to Review
All content under
attributes-registry
is autogenerated files. For styling issues/concerns, you can comment directly on jinja templates undertemplates/registry/markdown
.For issues where attribute registry "groups" are not displaying, you can comment on
templates/registry/markdown/weaver.yaml
where the configuration for resolving attribute registry exists.For issues on snippet generation (and moving from
local
tofull
in all snippets), comment directly on templates with problematic issues and we'll open bugs against Weaver to improve its out of the box support (Note: this will be moving to JINJA templates we would control in semconv repository eventually).Ready-For-Merge TODOs
Blocking
git diff
peer.md
is not generatingsystem.md
was missing in current registry.-
or_
as previously used.{{name}}.<key>
(@jsuereth)k8s
fragmentation fixes, so we don't getK 8 S
titles.full
jvm.buffer.pool.name
shows up aspool.name
.Nice to Have
id
in lieu ofbrief
weaver#127Changes
Update the entire
docs/attributes-registry
directory to be autogenreated from semantic convention YAML.check
to see if attribute registry is out of dateMerge requirement checklist
[chore]