-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Move system metric attributes to the registry #867
[chore] Move system metric attributes to the registry #867
Conversation
Add sub-sections
Add <!-- toc -->
Add deprecated attribtutes to the list.
7db66a0
to
893c4e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the state of this PR is "ready for review" already but my comment seems to be still unresolved?
I think we have concluded on having the registry in a signal generic form. In this I left some suggestions to remove any mention to "Metrics" from the registry's attributes.
And we will still need to override the system.cpu.state
within the system metrics spec.
Let me know @gregkalapos if I miss anything or there is anything that is unclear ;).
Sorry for the confusion - let's discussed it in that thread and depending on what we agree on, I'll move on with the suggestions. |
Co-authored-by: Chris Mark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank's @gregkalapos! Looks good from my side.
Changes
Moves
system.*
attributes to the registry from system metrics.Merge requirement checklist
[chore]