-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move HTTP client metrics out of .NET conventions #801
Merged
lmolkova
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:move-dotnet-metrics-experimental
Mar 14, 2024
Merged
Move HTTP client metrics out of .NET conventions #801
lmolkova
merged 10 commits into
open-telemetry:main
from
dynatrace-oss-contrib:move-dotnet-metrics-experimental
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyohannes
reviewed
Mar 7, 2024
antonfirsov
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
lmolkova
reviewed
Mar 7, 2024
13 tasks
lmolkova
approved these changes
Mar 12, 2024
@antonfirsov could you please take another look? |
also //cc @open-telemetry/dotnet-approvers @open-telemetry/semconv-dotnet-approver |
antonfirsov
reviewed
Mar 12, 2024
antonfirsov
approved these changes
Mar 12, 2024
AlexanderWert
approved these changes
Mar 14, 2024
trisch-me
reviewed
Mar 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #800
Changes
This PR moves HTTP client metrics (and one attribute) from the .NET metrics model to the general HTTP one.
It removes MD generation from .NET metric definition as it's frozen in time and should not get any updates or changes on the common metric.
It helps to untie .NET semconv stability from the unstable OTel parts it depends upon and helps with #781
Related to #785
Merge requirement checklist
[chore]