-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust process.command*
to be opt-in
#789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe command_args attributes should be defined as template attributes and have per-value opt-in mechanism similar to http headers. Created #790.
It can be done separately from this PR.
Should we also add notes to the properties about sensitive content as well as we do for URL for example? |
I'd just want to hear from @breedx-nr and his comment on #626 (comment) before we merge this. |
I took the liberty to fix the CI issues. Had to generate the markdown tables and add a change log. I think this is a breaking change. CC @open-telemetry/semconv-system-approvers |
Ah I totally missed the earlier notification, thank you @joaopgrassi for doing that. |
Note that this makes the conventions stricter and does not relax anything. Before, if you set one of the So I'm not sure that the change does what you want it to do. EDIT: Technically you could just change the requirement description from "conditionally_required: See alternative attributes below." to something like "conditionally_required: This should only be set as opt-in and another alternative (see below) should be preferred" |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@@ -0,0 +1,5 @@ | |||
change_type: breaking | |||
component: resource/process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be only process here, we don't have resource in registry
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@inssein please reopen PR again if you still want to implement this feature |
This would require to be rebased on top of the recent project reorg. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #626
Changes
I made it match the
container
resource.Merge requirement checklist
[chore]