Merge DB connection-level and call-level attributes #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Feb 28, 2024
trask
reviewed
Feb 28, 2024
trask
reviewed
Feb 28, 2024
trask
approved these changes
Feb 28, 2024
jack-berg
reviewed
Feb 28, 2024
jack-berg
approved these changes
Feb 28, 2024
joaopgrassi
approved these changes
Feb 29, 2024
alanwest
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merges connection and call-level attributes for databases.
DB instrumentations in the general case are operating on the logical/public surface level and not always aware of connections.
Separation into connection and call level is also confusing.
Extracted from #768, related to #690
Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.