Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove microsoft link to fix PR checks #701

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

trisch-me
Copy link
Contributor

Changes

Update link which now redirects to another url and causes markdown-link-check error

Merge requirement checklist

@trisch-me trisch-me requested review from a team February 7, 2024 13:40
@trisch-me
Copy link
Contributor Author

Hm it is still not working. @arminru do you know are there special settings for markdown check? I was thinking the problem is in redirecting but final working url is also causing check to fail

@arminru
Copy link
Member

arminru commented Feb 7, 2024

@trisch-me Sometimes the link check is a bit spotty, maybe the resolution and/or response is taking too long from the data center where the Github workflow is running. I'd not be surprised if re-running it once or twice would make it pass.
The settings don't override anything w.r.t. redirection: https://github.com/open-telemetry/semantic-conventions/blob/main/.markdown_link_check_config.json
In https://github.com/open-telemetry/opentelemetry.io they improved stability by introducing a cache for external reference checking but we haven't invested in setting this up in this repo here since it used to be working well enough for the most part.

@trisch-me
Copy link
Contributor Author

@arminru I thought so too, but it looks like it is failing for all PRs.
From config I see we take only "aliveStatusCodes": [200, 403]. The url returns 302 and redirects to another one. But I am not sure it is the issue here because current PR has new url.

Taking into account that it is always failing after 3 minutes it looks like there is some problem with tool itself and it raises timeout

docs/database/mssql.md Outdated Show resolved Hide resolved
Co-authored-by: Armin Ruech <[email protected]>
@trisch-me
Copy link
Contributor Author

Ok it is working now so the problem was with that particular url. But I'm not sure I see the reason why it was failing

@trask
Copy link
Member

trask commented Feb 7, 2024

Ok it is working now so the problem was with that particular url. But I'm not sure I see the reason why it was failing

we've seen issues in the java instrumentation repo with several sites rejecting bot requests: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/0a5c31193cb331dd47733a172db8d39c9e7016dd/.github/scripts/markdown-link-check-config.json#L7-L26

@trisch-me
Copy link
Contributor Author

Oh I see, so you mean that microsoft start to block requests from this block. This makes sense

@trisch-me trisch-me changed the title [chore] update microsoft link [chore] remove microsoft link to fix build Feb 7, 2024
@trisch-me trisch-me changed the title [chore] remove microsoft link to fix build [chore] remove microsoft link to fix PR checks Feb 7, 2024
@joaopgrassi joaopgrassi merged commit e2382e6 into open-telemetry:main Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants