-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] remove microsoft link to fix PR checks #701
Conversation
Hm it is still not working. @arminru do you know are there special settings for markdown check? I was thinking the problem is in redirecting but final working url is also causing check to fail |
@trisch-me Sometimes the link check is a bit spotty, maybe the resolution and/or response is taking too long from the data center where the Github workflow is running. I'd not be surprised if re-running it once or twice would make it pass. |
@arminru I thought so too, but it looks like it is failing for all PRs. Taking into account that it is always failing after 3 minutes it looks like there is some problem with tool itself and it raises timeout |
Co-authored-by: Armin Ruech <[email protected]>
Ok it is working now so the problem was with that particular url. But I'm not sure I see the reason why it was failing |
we've seen issues in the java instrumentation repo with several sites rejecting bot requests: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/0a5c31193cb331dd47733a172db8d39c9e7016dd/.github/scripts/markdown-link-check-config.json#L7-L26 |
Oh I see, so you mean that microsoft start to block requests from this block. This makes sense |
Changes
Update link which now redirects to another url and causes
markdown-link-check
errorMerge requirement checklist
[chore]