Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure messaging: settlement attributes and span names #697

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Update Azure messaging: settlement attributes and span names #697

merged 8 commits into from
Mar 1, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Feb 7, 2024 •
edited
Loading

Changes

  • Adds Azure Service Bus-specific attribute describing settlement type (complete, abandon, defer, dead_letter)
  • Clarifies operation names for settlement and deliver span

Merge requirement checklist

@lmolkova lmolkova mentioned this pull request Feb 13, 2024
Closed
3 tasks
@lmolkova lmolkova force-pushed the azure-sb-settlemet-spans-overrides branch from fbd87bf to 18c532f Compare February 23, 2024 22:54
@lmolkova lmolkova marked this pull request as ready for review February 23, 2024 22:54
@lmolkova lmolkova requested review from a team February 23, 2024 22:55
pyohannes
pyohannes approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@pyohannes pyohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nit-picks.

docs/messaging/azure-messaging.md Outdated Show resolved Hide resolved
docs/messaging/azure-messaging.md Outdated Show resolved Hide resolved
docs/messaging/azure-messaging.md Outdated Show resolved Hide resolved
@lmolkova lmolkova force-pushed the azure-sb-settlemet-spans-overrides branch from e49b42e to 32156ee Compare February 29, 2024 04:20
@joaopgrassi
Copy link
Member

@lmolkova Do you maybe want to set the stability on these before we merge?

@lmolkova lmolkova force-pushed the azure-sb-settlemet-spans-overrides branch from 9c3822d to 1215095 Compare February 29, 2024 17:54
@lmolkova lmolkova requested review from a team February 29, 2024 17:54
@lmolkova lmolkova force-pushed the azure-sb-settlemet-spans-overrides branch from 1215095 to 6e9552e Compare February 29, 2024 17:56
@joaopgrassi joaopgrassi merged commit e4930d3 into open-telemetry:main Mar 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmolkova @joaopgrassi @pyohannes