-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resource/host] Change type of host.cpu.stepping
to string
#665
Conversation
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with this change mostly assuming this is a rare/new field that isn't used much.
If someone can confirm this field is little used in the wild, that'd be ideal.
From a Github search, only the OpenTelemetry Collector resource detection processor system detector supports this attribute. It is not enabled by default and we have done similar changes to other |
I guess we need to update this PR to use the new changelog structure: https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry. @joaopgrassi is that correct? |
@ChrsMark yes that would be great, thanks! Then we are ready to merge :) |
05cd661
to
a8e0fbd
Compare
Signed-off-by: ChrsMark <[email protected]>
a8e0fbd
to
cdbe5c2
Compare
@joaopgrassi done cdbe5c2 |
Fixes #664
Changes
This PR changes the type of
host.cpu.stepping
tostring
in order to cover values liker1p1
as described at #664.Merge requirement checklist
host.cpu.stepping
should be string #664