Depluralize labels for pod and container resources #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
mx-psi
approved these changes
Jan 3, 2024
TylerHelmuth
reviewed
Jan 8, 2024
dashpole
approved these changes
Jan 8, 2024
Signed-off-by: ChrsMark <[email protected]>
pyohannes
approved these changes
Jan 9, 2024
arminru
approved these changes
Jan 9, 2024
jsuereth
approved these changes
Jan 9, 2024
TylerHelmuth
approved these changes
Jan 9, 2024
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
Signed-off-by: ChrsMark <[email protected]> Co-authored-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
Changes
This PR de-pluralizes the
container.labels.<key>andk8s.pod.labels.<key>attributes in order to ensure the consistency with other attributes of this "pattern":http.response.header.<key>k8s.pod.annotation.<key>Merge requirement checklist